Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-section): update to v2 #10959

Merged
merged 11 commits into from
Oct 2, 2023
Merged

feat(feature-section): update to v2 #10959

merged 11 commits into from
Oct 2, 2023

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Closes #10852

Description

Update feature section to v2

Changelog

Changed

  • deprecated feature-section-card-link in favor for card with link variation
  • readme and examples updated

@ariellalgilmore ariellalgilmore added package: web components Work necessary for the IBM.com Library web components package Needs design approval PRs on feature requests and new components have to get design approval before merge. v2: prep preparation items for Carbon for IBM.com V2 labels Sep 21, 2023
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner September 21, 2023 16:21
@ariellalgilmore ariellalgilmore linked an issue Sep 21, 2023 that may be closed by this pull request
[Component] Feature section #10852
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 21, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10959/index.html

Built with commit: ff4555734f9b55fbdb5ad8b5cabf2eb447abec6e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 21, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10959/index.html

Built with commit: ff4555734f9b55fbdb5ad8b5cabf2eb447abec6e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 21, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10959/index.html

Built with commit: ff4555734f9b55fbdb5ad8b5cabf2eb447abec6e

IgnacioBecerra
IgnacioBecerra approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just a small question below:

packages/styles/scss/components/feature-section/_feature-section.scss
Comment on lines +63 to +66
div[class^='#{$prefix}--col'] {
box-sizing: border-box;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's about style specificity, but I'm curious as to why it was done like this over .#{$prefix}--col?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am targetting this line:

carbon-for-ibm-dotcom/packages/web-components/src/components/feature-section/feature-section.ts

Line 70 in b5ecd5f

class="${prefix}--col-sm-4 ${prefix}--col-md-6 ${prefix}--col-lg-12">
, so just thought I would target any classes starting with .#{$prefix}--col

oliviaflory
oliviaflory approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 sobbing it's so perfect!

@oliviaflory oliviaflory removed the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Oct 2, 2023
@ariellalgilmore ariellalgilmore merged commit 2517dab into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Oct 2, 2023
4 of 7 checks passed
@ariellalgilmore ariellalgilmore deleted the feat/feature-section-v2 branch October 2, 2023 15:50
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Oct 17, 2023
@ariellalgilmore @kennylam
feat(feature-section): update to v2 (carbon-design-system#10959)
3b99a4c 
* feat(feature-section): v2 updates

* feat(feature-section): docs

* fix(feature-section): react wrapper story

* fix(Feature-section): design updates

* fix(migration): update docs

* fix(card): remove import

* Update dotcom-v2-migration.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviaflory oliviaflory oliviaflory approved these changes

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Feature section
4 participants
@ariellalgilmore @ibmdotcom-bot @IgnacioBecerra @oliviaflory